diff options
| author | Boris Kolpackov <boris@codesynthesis.com> | 2020-10-27 15:49:56 +0200 |
|---|---|---|
| committer | Boris Kolpackov <boris@codesynthesis.com> | 2020-10-27 15:49:56 +0200 |
| commit | b5f94681bf8697a52a832f5910b2d2a2d9501ff6 (patch) | |
| tree | 47a7d55ffbc885ac1780801dd187f854e1688d7c | |
| parent | 68b79c233c2371796c28ea6fdb595f091537d515 (diff) | |
Add comment on why uploading result via temporary file
| -rw-r--r-- | bbot/worker/worker.cxx | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/bbot/worker/worker.cxx b/bbot/worker/worker.cxx index 4f3e5ad..7e3c6e1 100644 --- a/bbot/worker/worker.cxx +++ b/bbot/worker/worker.cxx @@ -310,6 +310,12 @@ upload_manifest (tracer& trace, { try { + // Piping the data directly into curl's stdin sometimes results in the + // broken pipe error on the client and partial/truncated upload on the + // server. This happens quite regularly on older Linux distributions + // (e.g., Debian 8, Ubuntu 16.04) but also sometimes on Windows. On the + // other hand, uploading from a file appears to work reliably. + // #if 0 tftp_curl c (trace, path ("-"), |