aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrancois Kritzinger <francois@codesynthesis.com>2024-05-02 14:43:27 +0200
committerFrancois Kritzinger <francois@codesynthesis.com>2024-05-08 15:51:48 +0200
commite8b3c6eee5828d4668c048c1e9ecd5231816037f (patch)
tree810c376e5a9d27decf9b805b4935ce4ab61c5355
parentdcda4b6724e568edadfe65c02242a6407422f9a3 (diff)
Post-review changes
-rw-r--r--mod/mod-ci-github-gq.cxx6
-rw-r--r--mod/mod-ci-github.cxx2
2 files changed, 6 insertions, 2 deletions
diff --git a/mod/mod-ci-github-gq.cxx b/mod/mod-ci-github-gq.cxx
index 8e436e9..4a4f56d 100644
--- a/mod/mod-ci-github-gq.cxx
+++ b/mod/mod-ci-github-gq.cxx
@@ -494,10 +494,14 @@ namespace brep
build_state st,
optional<gq_built_result> br)
{
- // Must have a result if state is built. @@ du?
+ // Must have a result if state is built.
//
assert (st != build_state::built || br);
+ // Must have a details URL for building and built.
+ //
+ assert (!du.empty ());
+
string rq (
gq_serialize_request (
gq_mutation_update_check_run (rid,
diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx
index 9c084ba..dc21e0e 100644
--- a/mod/mod-ci-github.cxx
+++ b/mod/mod-ci-github.cxx
@@ -869,7 +869,7 @@ namespace brep
iat->token,
sd.repository_id,
*cr.node_id,
- "", // Don't update details_url again. @@
+ details_url (b),
build_state::built,
move (br)))
{