aboutsummaryrefslogtreecommitdiff
path: root/brep/handler
diff options
context:
space:
mode:
authorKaren Arutyunov <karen@codesynthesis.com>2023-05-19 13:47:15 +0300
committerKaren Arutyunov <karen@codesynthesis.com>2023-05-19 13:47:15 +0300
commit9d3853cef802cb25ccc5c6749293d76990a3030c (patch)
treeacaa4d3d1c2a042aeaa631808acb22e50dc47b16 /brep/handler
parente81faac093c1e9ee8f7dc710230c4b9e03b37d3a (diff)
Fix upload-bindist-clean and update INSTALL
Diffstat (limited to 'brep/handler')
-rw-r--r--brep/handler/upload/upload-bindist-clean.in14
1 files changed, 13 insertions, 1 deletions
diff --git a/brep/handler/upload/upload-bindist-clean.in b/brep/handler/upload/upload-bindist-clean.in
index 20c2b00..99914a7 100644
--- a/brep/handler/upload/upload-bindist-clean.in
+++ b/brep/handler/upload/upload-bindist-clean.in
@@ -187,7 +187,19 @@ for d in "${expired_dirs[@]}"; do
# Remove the package configuration directory.
#
- run rm -r "$d"
+ # Note that this directory contains files copied from a subdirectory of
+ # upload-data. These files are normally owned by the Apache2 user/group
+ # and have rw-r--r-- permissions. This script is normally executed as the
+ # brep user/group and thus the uploads root directory and all its
+ # subdirectories must have read, write, and execute permissions granted to
+ # the brep user, for example, by using ACL (see INSTALL file for
+ # details). Since cp preserves the file permissions by default, these
+ # files effective permissions will normally be r-- (read-only) for this
+ # script. In this case rm pops up the 'remove write-protected regular
+ # file' prompt by default prior to removing these files. To suppress the
+ # prompt we will pass the -f option to rm.
+ #
+ run rm -rf "$d"
# Remove the empty parent directories.
#