aboutsummaryrefslogtreecommitdiff
path: root/mod/mod-ci-github-gq.hxx
diff options
context:
space:
mode:
authorFrancois Kritzinger <francois@codesynthesis.com>2024-04-26 07:18:33 +0200
committerFrancois Kritzinger <francois@codesynthesis.com>2024-04-26 07:24:23 +0200
commit7209b7a672a4a079f81f1fd9629b23948e97636f (patch)
tree7d3d2f41db6fcfe57483d17295d80c05b24bbb85 /mod/mod-ci-github-gq.hxx
parentf1ea9ade2c50da39bf21a2d2410868d409c2a291 (diff)
Support GitHub conclusion in check run create/update
Diffstat (limited to 'mod/mod-ci-github-gq.hxx')
-rw-r--r--mod/mod-ci-github-gq.hxx12
1 files changed, 11 insertions, 1 deletions
diff --git a/mod/mod-ci-github-gq.hxx b/mod/mod-ci-github-gq.hxx
index 3d8c6cc..9331b2b 100644
--- a/mod/mod-ci-github-gq.hxx
+++ b/mod/mod-ci-github-gq.hxx
@@ -37,6 +37,11 @@ namespace brep
// state and the node ID. Return false and issue diagnostics if the request
// failed.
//
+ // The result_status is required if the build_state is built because GitHub
+ // does not allow a check run status of `completed` without a conclusion.
+ //
+ // @@ TODO Support output (title, summary, text).
+ //
bool
gq_create_check_run (check_run& cr,
const string& installation_access_token,
@@ -44,6 +49,7 @@ namespace brep
const string& head_sha,
const build&,
build_state,
+ optional<result_status>,
const build_queued_hints&,
const basic_mark& error);
@@ -53,7 +59,10 @@ namespace brep
// with the new state. Return false and issue diagnostics if the request
// failed.
//
- // @@ TODO Support conclusion, output, etc.
+ // The result_status is required if the build_state is built because GitHub
+ // does not allow updating a check run to `completed` without a conclusion.
+ //
+ // @@ TODO Support output (title, summary, text).
//
bool
gq_update_check_run (check_run& cr,
@@ -61,6 +70,7 @@ namespace brep
const string& repository_id,
const string& node_id,
build_state,
+ optional<result_status>,
const basic_mark& error);
}