diff options
author | Francois Kritzinger <francois@codesynthesis.com> | 2024-12-19 08:55:11 +0200 |
---|---|---|
committer | Francois Kritzinger <francois@codesynthesis.com> | 2025-01-06 14:11:36 +0200 |
commit | 30882629ba154c35915d0fada33e26a4b4a01513 (patch) | |
tree | 68fcaa3d07785635415514870f32a6395e9540c8 /mod/mod-ci-github.hxx | |
parent | af2472b97bade0da148eec43fe111fae4aea8174 (diff) |
ci-github: Address issues found during testing
- Update CRs if rebuilding CR of archived tenant
Was re-creating them before despite both node ids being available.
- handle_check_run_rerequest(): get IAT earlier
- Rearrange order of functions
Diffstat (limited to 'mod/mod-ci-github.hxx')
-rw-r--r-- | mod/mod-ci-github.hxx | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/mod/mod-ci-github.hxx b/mod/mod-ci-github.hxx index 4f69f5c..4fcfa7e 100644 --- a/mod/mod-ci-github.hxx +++ b/mod/mod-ci-github.hxx @@ -82,47 +82,45 @@ namespace brep virtual void init (cli::scanner&); - // @@ TODO Reorder handlers: push, pull_request, then check_suite. - - // Handle the check_suite event `rerequested` action. + // Handle push events (branch push). // // If warning_success is true, then map result_status::warning to SUCCESS // and to FAILURE otherwise. // bool - handle_check_suite_rerequest (gh_check_suite_event, bool warning_success); + handle_branch_push (gh_push_event, bool warning_success); - // Handle the check_suite event `completed` action. + // Handle the pull_request event `opened` and `synchronize` actions. // // If warning_success is true, then map result_status::warning to SUCCESS // and to FAILURE otherwise. // bool - handle_check_suite_completed (gh_check_suite_event, bool warning_success); + handle_pull_request (gh_pull_request_event, bool warning_success); - // Handle the check_run event `rerequested` action. + // Handle the check_suite event `rerequested` action. // // If warning_success is true, then map result_status::warning to SUCCESS // and to FAILURE otherwise. // bool - handle_check_run_rerequest (const gh_check_run_event&, bool warning_success); + handle_check_suite_rerequest (gh_check_suite_event, bool warning_success); - // Handle the pull_request event `opened` and `synchronize` actions. + // Handle the check_suite event `completed` action. // // If warning_success is true, then map result_status::warning to SUCCESS // and to FAILURE otherwise. // bool - handle_pull_request (gh_pull_request_event, bool warning_success); + handle_check_suite_completed (gh_check_suite_event, bool warning_success); - // Handle push events (branch push). + // Handle the check_run event `rerequested` action. // // If warning_success is true, then map result_status::warning to SUCCESS // and to FAILURE otherwise. // bool - handle_branch_push (gh_push_event, bool warning_success); + handle_check_run_rerequest (const gh_check_run_event&, bool warning_success); // Build a check run details_url for a build. // |