aboutsummaryrefslogtreecommitdiff
path: root/mod
diff options
context:
space:
mode:
authorFrancois Kritzinger <francois@codesynthesis.com>2024-04-25 10:10:02 +0200
committerFrancois Kritzinger <francois@codesynthesis.com>2024-06-05 09:12:46 +0200
commitd73c5fa02b39ef92f9e97672a1aa3360bf7d9683 (patch)
tree4fefe8ee17f44718ce8eff0175d7bcf8c72f31eb /mod
parentc72e13908761a527ed929d494f8e38fd8dafd56f (diff)
Post-review changes
Diffstat (limited to 'mod')
-rw-r--r--mod/mod-ci-github.cxx16
1 files changed, 7 insertions, 9 deletions
diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx
index 426dc60..dd9cfc0 100644
--- a/mod/mod-ci-github.cxx
+++ b/mod/mod-ci-github.cxx
@@ -633,7 +633,7 @@ namespace brep
if (scr->node_id)
{
cr = move (*scr);
- cr.state_synced = false;
+ cr->state_synced = false;
}
else
; // Network error during queued notification, ignore.
@@ -669,7 +669,7 @@ namespace brep
iat = &sd.installation_access;
// Note: we treat the failure to obtain the installation access token the
- // same as the failure to notify GitHub (state is updated by not marked
+ // same as the failure to notify GitHub (state is updated but not marked
// synced).
//
if (iat != nullptr)
@@ -677,16 +677,14 @@ namespace brep
if (gq_update_check_run (*cr,
iat->token,
sd.repository_id,
- *cr.node_id,
+ *cr->node_id,
build_state::building,
error))
{
// Do nothing further if the state was already built on GitHub (note
- // that this is based on the above-mentioned special GitHub semanitcs
+ // that this is based on the above-mentioned special GitHub semantics
// of preventing changes to the built status).
//
- // @@ Can we confirm this?
- //
if (cr->state == build_state::built)
{
warn << "check run " << bid << ": already in built state on GitHub";
@@ -694,14 +692,14 @@ namespace brep
return nullptr;
}
- assert (cr.state == build_state::building);
+ assert (cr->state == build_state::building);
- l3 ([&]{trace << "updated check_run { " << cr << " }";});
+ l3 ([&]{trace << "updated check_run { " << *cr << " }";});
}
}
return [iat = move (new_iat),
- cr = move (cr),
+ cr = move (*cr),
error = move (error),
warn = move (warn)] (const tenant_service& ts) -> optional<string>
{