aboutsummaryrefslogtreecommitdiff
path: root/mod
diff options
context:
space:
mode:
Diffstat (limited to 'mod')
-rw-r--r--mod/mod-ci-github-gh.cxx4
-rw-r--r--mod/mod-ci-github.cxx13
2 files changed, 9 insertions, 8 deletions
diff --git a/mod/mod-ci-github-gh.cxx b/mod/mod-ci-github-gh.cxx
index ad986e3..90389f3 100644
--- a/mod/mod-ci-github-gh.cxx
+++ b/mod/mod-ci-github-gh.cxx
@@ -22,7 +22,7 @@ namespace brep
case build_state::built: return "COMPLETED";
}
- assert (false);
+ return ""; // Should never reach.
}
// Return the build_state corresponding to a GitHub check run status
@@ -63,7 +63,7 @@ namespace brep
to_string (rs));
}
- assert (false);
+ return ""; // Should never reach.
}
string
diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx
index fc3fca3..d3c8407 100644
--- a/mod/mod-ci-github.cxx
+++ b/mod/mod-ci-github.cxx
@@ -872,7 +872,7 @@ namespace brep
to_string (rs));
}
- assert (false);
+ return ""; // Should never reach.
};
// Prepare the check run's summary field (the build information in an
@@ -885,10 +885,11 @@ namespace brep
ostringstream os;
xml::serializer s (os, "check_run_summary");
- // @@ TMP Hack required to disable XML element name prefixes (which
- // GitHub does not like). The XHTML elsewhere in brep always
- // starts with an <html> element which sets up the
- // namespace/prefix just like this.
+ // This hack is required to disable XML element name prefixes (which
+ // GitHub does not like). Note that this adsd an xmlns declaration for
+ // the XHTML namespace which for now GitHub appears to ignore. If that
+ // ever becomes a problem, then we should redo this with raw XML
+ // serializer calls.
//
struct table: element
{
@@ -977,7 +978,7 @@ namespace brep
//
gq_built_result br (gh_to_conclusion (*b.status, sd.warning_success),
circle (*b.status) + ' ' +
- ucase (to_string (*b.status)),
+ ucase (to_string (*b.status)),
move (sm));
if (cr.node_id)