From 9d3853cef802cb25ccc5c6749293d76990a3030c Mon Sep 17 00:00:00 2001 From: Karen Arutyunov Date: Fri, 19 May 2023 13:47:15 +0300 Subject: Fix upload-bindist-clean and update INSTALL --- brep/handler/upload/upload-bindist-clean.in | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) (limited to 'brep/handler') diff --git a/brep/handler/upload/upload-bindist-clean.in b/brep/handler/upload/upload-bindist-clean.in index 20c2b00..99914a7 100644 --- a/brep/handler/upload/upload-bindist-clean.in +++ b/brep/handler/upload/upload-bindist-clean.in @@ -187,7 +187,19 @@ for d in "${expired_dirs[@]}"; do # Remove the package configuration directory. # - run rm -r "$d" + # Note that this directory contains files copied from a subdirectory of + # upload-data. These files are normally owned by the Apache2 user/group + # and have rw-r--r-- permissions. This script is normally executed as the + # brep user/group and thus the uploads root directory and all its + # subdirectories must have read, write, and execute permissions granted to + # the brep user, for example, by using ACL (see INSTALL file for + # details). Since cp preserves the file permissions by default, these + # files effective permissions will normally be r-- (read-only) for this + # script. In this case rm pops up the 'remove write-protected regular + # file' prompt by default prior to removing these files. To suppress the + # prompt we will pass the -f option to rm. + # + run rm -rf "$d" # Remove the empty parent directories. # -- cgit v1.1