From 6287cfd1c0dbe34f9746980f935e4543883b3787 Mon Sep 17 00:00:00 2001
From: Boris Kolpackov <boris@codesynthesis.com>
Date: Mon, 20 Jan 2025 09:40:01 +0200
Subject: Review 1

---
 mod/mod-ci-github.cxx | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

(limited to 'mod')

diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx
index b203f94..45a9d14 100644
--- a/mod/mod-ci-github.cxx
+++ b/mod/mod-ci-github.cxx
@@ -3119,12 +3119,12 @@ namespace brep
     //   @d2586f57-21dc-40b7-beb2-6517ad7917dd (37 characters)
     //   <brep-root>/@d2586f57-21dc-40b7-beb2-6517ad7917dd
     //
-    if (!u.path || u.path->size () < 37)
+    if (!u.path)
       return nullopt;
 
     {
-      size_t p (u.path->find_first_of ('@'));
-      if (p > (u.path->size () - 37))
+      size_t p (u.path->find ('@'));
+      if (p == string::npos || u.path->size () - p != 37)
         return nullopt; // Tenant not found or too short.
 
       r.package.tenant = u.path->substr (p + 1);
@@ -3183,8 +3183,8 @@ namespace brep
 
         // Note: parsing code based on mod/mod-builds.cxx.
         //
-        size_t p (v.find_first_of ('-'));
-        if (p >= v.size () - 1)
+        size_t p (v.find ('-'));
+        if (p == string::npos || p >= v.size () - 1)
           return nullopt; // Invalid format.
 
         r.toolchain_name    = v.substr (0, p);
-- 
cgit v1.1