1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
|
// file : mod/mod-build-result.cxx -*- C++ -*-
// license : MIT; see accompanying LICENSE file
#include <mod/mod-build-result.hxx>
#include <odb/database.hxx>
#include <odb/transaction.hxx>
#include <libbutl/manifest-parser.hxx>
#include <libbutl/manifest-serializer.hxx>
#include <libbbot/manifest.hxx>
#include <web/server/module.hxx>
#include <libbrep/build.hxx>
#include <libbrep/build-odb.hxx>
#include <libbrep/build-package.hxx>
#include <libbrep/build-package-odb.hxx>
#include <mod/build.hxx> // send_notification_email()
#include <mod/module-options.hxx>
#include <mod/tenant-service.hxx>
using namespace std;
using namespace butl;
using namespace bbot;
using namespace brep::cli;
using namespace odb::core;
brep::build_result::
build_result (const tenant_service_map& tsm)
: tenant_service_map_ (tsm)
{
}
// While currently the user-defined copy constructor is not required (we don't
// need to deep copy nullptr's), it is a good idea to keep the placeholder
// ready for less trivial cases.
//
brep::build_result::
build_result (const build_result& r, const tenant_service_map& tsm)
: build_result_module (r),
options_ (r.initialized_ ? r.options_ : nullptr),
tenant_service_map_ (tsm)
{
}
void brep::build_result::
init (scanner& s)
{
options_ = make_shared<options::build_result> (
s, unknown_mode::fail, unknown_mode::fail);
if (options_->build_config_specified ())
build_result_module::init (*options_, *options_);
if (options_->root ().empty ())
options_->root (dir_path ("/"));
}
bool brep::build_result::
handle (request& rq, response&)
{
using brep::version; // Not to confuse with module::version.
HANDLER_DIAG;
if (build_db_ == nullptr)
throw invalid_request (501, "not implemented");
// Make sure no parameters passed.
//
try
{
// Note that we expect the result request manifest to be posted and so
// consider parameters from the URL only.
//
name_value_scanner s (rq.parameters (0 /* limit */, true /* url_only */));
params::build_result (s, unknown_mode::fail, unknown_mode::fail);
}
catch (const cli::exception& e)
{
throw invalid_request (400, e.what ());
}
result_request_manifest rqm;
try
{
// We fully cache the request content to be able to retry the request
// handling if odb::recoverable is thrown (see database-module.cxx for
// details).
//
size_t limit (options_->build_result_request_max_size ());
manifest_parser p (rq.content (limit, limit), "result_request_manifest");
rqm = result_request_manifest (p);
}
catch (const manifest_parsing& e)
{
throw invalid_request (400, e.what ());
}
// Parse the task response session and make sure the session matches tenant
// and the result manifest's package name, and version.
//
parse_session_result session;
const build_id& id (session.id);
try
{
// Note: also verifies that the tenant matches the session.
//
session = parse_session (rqm.session);
if (rqm.result.name != id.package.name)
throw invalid_argument ("package name mismatch");
if (rqm.result.version != session.package_version)
throw invalid_argument ("package version mismatch");
}
catch (const invalid_argument& e)
{
throw invalid_request (400, string ("invalid session: ") + e.what ());
}
// If the session expired (no such configuration, package, etc), then we log
// this case with the warning severity and respond with the 200 HTTP code as
// if the session is valid. The thinking is that this is a problem with the
// controller's setup (expires too fast), not with the agent's.
//
// Note, though, that there can be quite a common situation when a build
// machine is suspended by the bbot agent due to the build timeout. In this
// case the task result request may arrive anytime later (after the issue is
// investigated, etc) with the abort or abnormal status. By that arrival
// time a new build task may already be issued/completed for this package
// build configuration or this configuration may even be gone (brep has been
// reconfigured, package has gone, etc). We will log no warning in this
// case, assuming that such an expiration is not a problem with the
// controller's setup.
//
shared_ptr<build> b;
result_status rs (rqm.result.status);
auto warn_expired = [&rqm, &warn, &b, &session, rs] (const string& d)
{
if (!((b == nullptr || b->timestamp > session.timestamp) &&
(rs == result_status::abort || rs == result_status::abnormal)))
warn << "session '" << rqm.session << "' expired: " << d;
};
// Make sure the build configuration still exists.
//
const build_target_config* tc;
{
auto i (target_conf_map_->find (
build_target_config_id {id.target, id.target_config_name}));
if (i == target_conf_map_->end ())
{
warn_expired ("no build configuration");
return true;
}
tc = i->second;
}
// Load and update the package build configuration (if present).
//
// NULL if the package build doesn't exist or is not updated for any reason
// (authentication failed, etc) or the configuration is excluded by the
// package.
//
shared_ptr<build> bld;
// The built package configuration.
//
// Not NULL if bld is not NULL.
//
shared_ptr<build_package> pkg;
build_package_config* cfg (nullptr);
// Don't send email to the build-email address for the success-to-success
// status change, unless the build was forced.
//
bool build_notify (false);
bool unforced (true);
// If the package is built (result status differs from interrupt, etc) and
// the package tenant has a third-party service state associated with it,
// then check if the tenant_service_build_built callback is registered for
// the type of the associated service. If it is, then stash the state, the
// build object, and the callback pointer for the subsequent service `built`
// notification. Note that we send this notification for the skip result as
// well, since it is semantically equivalent to the previous build result
// with the actual build process being optimized out.
//
// If the package build is interrupted and the tenant_service_build_queued
// callback is associated with the package tenant, then stash the state, the
// build object, and the callback pointer and calculate the hints for the
// subsequent service `queued` notification.
//
const tenant_service_build_built* tsb (nullptr);
const tenant_service_build_queued* tsq (nullptr);
optional<pair<tenant_service, shared_ptr<build>>> tss;
tenant_service_build_queued::build_queued_hints qhs;
// Acquire the database connection for the subsequent transactions.
//
// Note that we will release it prior to any potentially time-consuming
// operations (such as HTTP requests) and re-acquire it again afterwards,
// if required.
//
connection_ptr conn (build_db_->connection ());
// Note that if the session authentication fails (probably due to the
// authentication settings change), then we log this case with the warning
// severity and respond with the 200 HTTP code as if the challenge is
// valid. The thinking is that we shouldn't alarm a law-abaiding agent and
// shouldn't provide any information to a malicious one.
//
{
transaction t (conn->begin ());
package_build pb;
auto build_timestamp = [&b] ()
{
return to_string (
chrono::duration_cast<std::chrono::nanoseconds> (
b->timestamp.time_since_epoch ()).count ());
};
if (!build_db_->query_one<package_build> (
query<package_build>::build::id == id, pb))
{
warn_expired ("no package build");
}
else if ((b = move (pb.build))->state != build_state::building)
{
warn_expired ("package configuration state is " + to_string (b->state) +
", force state " + to_string (b->force) +
", timestamp " + build_timestamp ());
}
else if (b->timestamp != session.timestamp)
{
warn_expired ("non-matching timestamp " + build_timestamp ());
}
else if (authenticate_session (*options_, rqm.challenge, *b, rqm.session))
{
const tenant_service_base* ts (nullptr);
shared_ptr<build_tenant> t (build_db_->load<build_tenant> (b->tenant));
if (t->service)
{
auto i (tenant_service_map_.find (t->service->type));
if (i != tenant_service_map_.end ())
ts = i->second.get ();
}
// If the build is interrupted, then revert it to the original built
// state if this is a rebuild. Otherwise (initial build), turn the build
// into the queued state if the tenant_service_build_queued callback is
// registered for the package tenant and delete it from the database
// otherwise.
//
// Note that if the tenant_service_build_queued callback is registered,
// we always send the `queued` notification for the interrupted build,
// even when we reverse it to the original built state. We could also
// turn the build into the queued state in this case, but it feels that
// there is no harm in keeping the previous build information available
// for the user.
//
if (rs == result_status::interrupt)
{
// Schedule the `queued` notification, if the
// tenant_service_build_queued callback is registered for the tenant.
//
tsq = dynamic_cast<const tenant_service_build_queued*> (ts);
if (b->status) // Is this a rebuild?
{
b->state = build_state::built;
// Keep the force rebuild indication. Note that the forcing state is
// only valid for the building state.
//
if (b->force == force_state::forcing)
b->force = force_state::forced;
// Cleanup the interactive build login information.
//
b->interactive = nullopt;
// Cleanup the authentication data.
//
b->agent_fingerprint = nullopt;
b->agent_challenge = nullopt;
// Note that we are unable to restore the pre-rebuild timestamp
// since it has been overwritten when the build task was issued.
// That, however, feels ok and we just keep it unchanged.
//
// Moreover, we actually use the fact that the build's timestamp is
// greater then its soft_timestamp as an indication that the build
// object represents the interrupted rebuild (see the build_task
// handler for details).
//
// @@ Actually, we also unable to restore the pre-rebuild machine
// and auxiliary machines, which are also displayed in the build
// log and may potentially be confusing. Should we drop them from
// the log in this case or replace with the "machine: unknown"
// record?
build_db_->update (b);
}
else // Initial build.
{
if (tsq != nullptr)
{
// Since this is not a rebuild, there are no operation results and
// thus we don't need to load the results section to erase results
// from the database.
//
assert (b->results.empty ());
*b = build (move (b->tenant),
move (b->package_name),
move (b->package_version),
move (b->target),
move (b->target_config_name),
move (b->package_config_name),
move (b->toolchain_name),
move (b->toolchain_version));
build_db_->update (b);
}
else
build_db_->erase (b);
}
// If we ought to call the tenant_service_build_queued::build_queued()
// callback, then also set the package tenant's queued timestamp to
// the current time to prevent the notifications race (see
// tenant::queued_timestamp for details).
//
if (tsq != nullptr)
{
// Calculate the tenant service hints.
//
buildable_package_count tpc (
build_db_->query_value<buildable_package_count> (
query<buildable_package_count>::build_tenant::id == t->id));
shared_ptr<build_package> p (
build_db_->load<build_package> (b->id.package));
qhs = tenant_service_build_queued::build_queued_hints {
tpc == 1, p->configs.size () == 1};
// Set the package tenant's queued timestamp.
//
t->queued_timestamp = system_clock::now ();
build_db_->update (t);
}
}
else // Regular or skip build result.
{
// Schedule the `built` notification, if the
// tenant_service_build_built callback is registered for the tenant.
//
tsb = dynamic_cast<const tenant_service_build_built*> (ts);
// Verify the result status/checksums.
//
// Specifically, if the result status is skip, then it can only be in
// response to the soft rebuild task (all checksums are present in the
// build object) and the result checksums must match the build object
// checksums. On verification failure respond with the bad request
// HTTP code (400).
//
if (rs == result_status::skip)
{
if (!b->agent_checksum ||
!b->worker_checksum ||
!b->dependency_checksum)
throw invalid_request (400, "unexpected skip result status");
// Can only be absent for initial build, in which case the
// checksums are also absent and we would end up with the above
// 400 response.
//
assert (b->status);
// Verify that the result checksum matches the build checksum and
// throw invalid_request(400) if that's not the case.
//
auto verify = [] (const string& build_checksum,
const optional<string>& result_checksum,
const char* what)
{
if (!result_checksum)
throw invalid_request (
400,
string (what) + " checksum is expected for skip result status");
if (*result_checksum != build_checksum)
throw invalid_request (
400,
string (what) + " checksum '" + build_checksum +
"' is expected instead of '" + *result_checksum +
"' for skip result status");
};
verify (*b->agent_checksum, rqm.agent_checksum, "agent");
verify (*b->worker_checksum,
rqm.result.worker_checksum,
"worker");
verify (*b->dependency_checksum,
rqm.result.dependency_checksum,
"dependency");
}
unforced = (b->force == force_state::unforced);
build_notify = !(rs == result_status::success &&
b->status &&
*b->status == rs &&
unforced);
b->state = build_state::built;
b->force = force_state::unforced;
// Cleanup the interactive build login information.
//
b->interactive = nullopt;
// Cleanup the authentication data.
//
b->agent_fingerprint = nullopt;
b->agent_challenge = nullopt;
b->timestamp = system_clock::now ();
b->soft_timestamp = b->timestamp;
// If the result status is other than skip, then save the status,
// results, and checksums and update the hard timestamp. Also stash
// the service notification information, if present.
//
if (rs != result_status::skip)
{
b->status = rs;
b->hard_timestamp = b->soft_timestamp;
// Mark the section as loaded, so results are updated.
//
b->results_section.load ();
b->results = move (rqm.result.results);
// Save the checksums.
//
b->agent_checksum = move (rqm.agent_checksum);
b->worker_checksum = move (rqm.result.worker_checksum);
b->dependency_checksum = move (rqm.result.dependency_checksum);
}
build_db_->update (b);
pkg = build_db_->load<build_package> (b->id.package);
cfg = find (b->package_config_name, pkg->configs);
// The package configuration should be present (see mod-builds.cxx for
// details) but if it is not, let's log the warning.
//
if (cfg != nullptr)
{
// Don't send the build notification email if the task result is
// `skip`, the configuration is hidden, or is now excluded by the
// package.
//
if (rs != result_status::skip && !belongs (*tc, "hidden"))
{
build_db_->load (*pkg, pkg->constraints_section);
if (!exclude (*cfg, pkg->builds, pkg->constraints, *tc))
bld = b;
}
}
else
warn << "cannot find configuration '" << b->package_config_name
<< "' for package " << pkg->id.name << '/' << pkg->version;
}
// If required, stash the service notification information.
//
if (tsb != nullptr || tsq != nullptr)
tss = make_pair (move (*t->service), move (b));
}
t.commit ();
}
// We either notify about the queued build or notify about the built package
// or don't notify at all.
//
assert (tsb == nullptr || tsq == nullptr);
// If the package build is interrupted and the tenant-associated third-party
// service needs to be notified about the queued builds, then call the
// tenant_service_build_queued::build_queued() callback function and update
// the service state, if requested.
//
if (tsq != nullptr)
{
assert (tss); // Wouldn't be here otherwise.
const tenant_service& ss (tss->first);
vector<build> qbs;
qbs.push_back (move (*tss->second));
// Release the database connection since build_queued() notification can
// potentially be time-consuming (e.g., it may perform an HTTP request).
//
conn.reset ();
if (auto f = tsq->build_queued (ss,
qbs,
build_state::building,
qhs,
log_writer_))
{
conn = build_db_->connection ();
update_tenant_service_state (conn, qbs.back ().tenant, f);
}
}
// If a third-party service needs to be notified about the built package,
// then call the tenant_service_build_built::build_built() callback function
// and update the service state, if requested.
//
if (tsb != nullptr)
{
assert (tss); // Wouldn't be here otherwise.
const tenant_service& ss (tss->first);
const build& b (*tss->second);
// Release the database connection since build_built() notification can
// potentially be time-consuming (e.g., it may perform an HTTP request).
//
conn.reset ();
if (auto f = tsb->build_built (ss, b, log_writer_))
{
conn = build_db_->connection ();
update_tenant_service_state (conn, b.tenant, f);
}
}
if (bld != nullptr)
{
// Don't sent the notification email for success-to-success status change,
// etc.
//
if (!build_notify)
(cfg->email ? cfg->email : pkg->build_email) = email ();
if (conn == nullptr)
conn = build_db_->connection ();
send_notification_email (*options_,
conn,
*bld,
*pkg,
*cfg,
unforced ? "build" : "rebuild",
error,
verb_ >= 2 ? &trace : nullptr);
}
return true;
}
|