1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
|
// file : mod/mod-build-task.cxx -*- C++ -*-
// copyright : Copyright (c) 2014-2017 Code Synthesis Ltd
// license : MIT; see accompanying LICENSE file
#include <mod/mod-build-task.hxx>
#include <map>
#include <chrono>
#include <odb/database.hxx>
#include <odb/transaction.hxx>
#include <odb/schema-catalog.hxx>
#include <libbutl/sha256.hxx>
#include <libbutl/utility.hxx> // compare_c_string
#include <libbutl/openssl.hxx>
#include <libbutl/fdstream.hxx> // nullfd
#include <libbutl/filesystem.hxx> // path_match()
#include <libbutl/process-io.hxx>
#include <libbutl/manifest-parser.hxx>
#include <libbutl/manifest-serializer.hxx>
#include <libbbot/manifest.hxx>
#include <libbbot/build-config.hxx>
#include <web/module.hxx>
#include <libbrep/build.hxx>
#include <libbrep/build-odb.hxx>
#include <libbrep/package.hxx>
#include <libbrep/package-odb.hxx>
#include <mod/options.hxx>
using namespace std;
using namespace butl;
using namespace bbot;
using namespace brep::cli;
using namespace odb::core;
// While currently the user-defined copy constructor is not required (we don't
// need to deep copy nullptr's), it is a good idea to keep the placeholder
// ready for less trivial cases.
//
brep::build_task::
build_task (const build_task& r)
: database_module (r),
options_ (r.initialized_ ? r.options_ : nullptr)
{
}
void brep::build_task::
init (scanner& s)
{
MODULE_DIAG;
options_ = make_shared<options::build_task> (
s, unknown_mode::fail, unknown_mode::fail);
database_module::init (static_cast<options::package_db> (*options_),
options_->package_db_retry ());
if (options_->build_config_specified ())
{
database_module::init (static_cast<options::build> (*options_),
static_cast<options::build_db> (*options_),
options_->build_db_retry ());
// Check that the database 'build' schema matches the current one. It's
// enough to perform the check in just a single module implementation
// (more details in the comment in package_search::init()).
//
const string ds ("build");
if (schema_catalog::current_version (*build_db_, ds) !=
build_db_->schema_version (ds))
fail << "database 'build' schema differs from the current one (module "
<< BREP_VERSION_ID << ")";
}
if (options_->root ().empty ())
options_->root (dir_path ("/"));
}
bool brep::build_task::
handle (request& rq, response& rs)
{
MODULE_DIAG;
if (build_db_ == nullptr)
throw invalid_request (501, "not implemented");
params::build_task params;
try
{
name_value_scanner s (rq.parameters ());
params = params::build_task (s, unknown_mode::fail, unknown_mode::fail);
}
catch (const cli::exception& e)
{
throw invalid_request (400, e.what ());
}
task_request_manifest tqm;
try
{
size_t limit (options_->build_task_request_max_size ());
manifest_parser p (rq.content (limit, limit), "task_request_manifest");
tqm = task_request_manifest (p);
}
catch (const manifest_parsing& e)
{
throw invalid_request (400, e.what ());
}
// Obtain the agent's public key fingerprint if requested. If the fingerprint
// is requested but is not present in the request or is unknown, then respond
// with 401 HTTP code (unauthorized).
//
optional<string> agent_fp;
if (bot_agent_keys_ != nullptr)
{
if (!tqm.fingerprint ||
bot_agent_keys_->find (*tqm.fingerprint) == bot_agent_keys_->end ())
throw invalid_request (401, "unauthorized");
agent_fp = move (tqm.fingerprint);
}
task_response_manifest tsm;
// Map build configurations to machines that are capable of building them.
// The first matching machine is selected for each configuration. Also
// create the configuration name list for use in database queries.
//
struct config_machine
{
const build_config* config;
machine_header_manifest* machine;
};
using config_machines = map<const char*, config_machine, compare_c_string>;
cstrings cfg_names;
config_machines cfg_machines;
for (const auto& c: *build_conf_)
{
for (auto& m: tqm.machines)
{
if (path_match (c.machine_pattern, m.name) &&
cfg_machines.insert (
make_pair (c.name.c_str (), config_machine ({&c, &m}))).second)
cfg_names.push_back (c.name.c_str ());
}
}
// Go through packages until we find one that has no build configuration
// present in the database, or is in the building state but expired
// (collectively called unbuilt). If such a package configuration is found
// then put it into the building state, set the current timestamp and respond
// with the task for building this package configuration.
//
// While trying to find a non-built package configuration we will also
// collect the list of the built package configurations which it's time to
// rebuilt. So if no unbuilt package is found, we will pickup one to
// rebuild. The rebuild preference is given in the following order: the
// greater force state, the greater overall status, the lower timestamp.
//
if (!cfg_machines.empty ())
{
vector<shared_ptr<build>> rebuilds;
// Create the task response manifest. The package must have the internal
// repository loaded.
//
auto task = [this] (shared_ptr<build>&& b,
shared_ptr<package>&& p,
const config_machine& cm) -> task_response_manifest
{
uint64_t ts (
chrono::duration_cast<std::chrono::nanoseconds> (
b->timestamp.time_since_epoch ()).count ());
string session (b->package_name + '/' + b->package_version.string () +
'/' + b->configuration +
'/' + b->toolchain_version.string () +
'/' + to_string (ts));
string result_url (options_->host () + options_->root ().string () +
"?build-result");
lazy_shared_ptr<repository> r (p->internal_repository);
strings fp;
if (r->certificate)
fp.emplace_back (move (r->certificate->fingerprint));
task_manifest task (move (b->package_name),
move (b->package_version),
move (r->location),
move (fp),
cm.machine->name,
cm.config->target,
cm.config->vars);
return task_response_manifest (move (session),
move (b->agent_challenge),
move (result_url),
move (task));
};
// Calculate the build (building state) or rebuild (built state) expiration
// time for package configurations
//
timestamp now (timestamp::clock::now ());
auto expiration = [&now] (size_t timeout) -> timestamp
{
return now - chrono::seconds (timeout);
};
auto expiration_ns = [&expiration] (size_t timeout) -> uint64_t
{
return chrono::duration_cast<chrono::nanoseconds> (
expiration (timeout).time_since_epoch ()).count ();
};
uint64_t normal_result_expiration_ns (
expiration_ns (options_->build_result_timeout ()));
uint64_t forced_result_expiration_ns (
expiration_ns (options_->build_forced_rebuild_timeout ()));
timestamp normal_rebuild_expiration (
expiration (options_->build_normal_rebuild_timeout ()));
timestamp forced_rebuild_expiration (
expiration (options_->build_forced_rebuild_timeout ()));
// Return the challenge (nonce) if brep is configured to authenticate bbot
// agents. Return nullopt otherwise.
//
// Nonce generator must guarantee a probabilistically insignificant chance
// of repeating a previously generated value. The common approach is to use
// counters or random number generators (alone or in combination), that
// produce values of the sufficient length. 64-bit non-repeating and
// 512-bit random numbers are considered to be more than sufficient for
// most practical purposes.
//
// We will produce the challenge as the sha256sum of the 512-bit random
// number and the 64-bit current timestamp combination. The latter is
// not really a non-repeating counter and can't be used alone. However
// adding it is a good and cheap uniqueness improvement.
//
auto challenge = [&agent_fp, &now, &fail, &trace, this] ()
{
optional<string> r;
if (agent_fp)
{
try
{
auto print_args = [&trace, this] (const char* args[], size_t n)
{
l2 ([&]{trace << process_args {args, n};});
};
openssl os (print_args,
nullfd, path ("-"), 2,
process_env (options_->openssl (),
options_->openssl_envvar ()),
"rand",
options_->openssl_option (), 64);
vector<char> nonce (os.in.read_binary ());
os.in.close ();
if (!os.wait () || nonce.size () != 64)
fail << "unable to generate nonce";
uint64_t t (chrono::duration_cast<std::chrono::nanoseconds> (
now.time_since_epoch ()).count ());
sha256 cs (nonce.data (), nonce.size ());
cs.append (&t, sizeof (t));
r = cs.string ();
}
catch (const system_error& e)
{
fail << "unable to generate nonce: " << e;
}
}
return r;
};
// Convert butl::standard_version type to brep::version.
//
brep::version toolchain_version (tqm.toolchain_version.string ());
// Prepare the package version prepared query.
//
// Note that the number of packages can be large and so, in order not to
// hold locks for too long, we will restrict the number of packages being
// queried in a single transaction. To achieve this we will iterate through
// packages using the OFFSET/LIMIT pair and sort the query result.
//
// Note that this approach can result in missing some packages or
// iterating multiple times over some of them. However there is nothing
// harmful in that: updates are infrequent and missed packages will be
// picked up on the next request.
//
using pkg_query = query<package_version>;
using prep_pkg_query = prepared_query<package_version>;
size_t offset (0); // See the package version query.
// Skip external and stub packages.
//
pkg_query pq (pkg_query::package::internal_repository.is_not_null () &&
compare_version_ne (pkg_query::package::id.version,
wildcard_version,
false));
// Filter by repositories display names (if requested).
//
const vector<string>& rp (params.repository ());
if (!rp.empty ())
pq = pq &&
pkg_query::repository::display_name.in_range (rp.begin (), rp.end ());
// Specify the portion.
//
pq += "ORDER BY" +
pkg_query::package::id.name + "," +
pkg_query::package::id.version.epoch + "," +
pkg_query::package::id.version.canonical_upstream + "," +
pkg_query::package::id.version.canonical_release + "," +
pkg_query::package::id.version.revision +
"OFFSET" + pkg_query::_ref (offset) + "LIMIT 50";
connection_ptr pkg_conn (package_db_->connection ());
prep_pkg_query pkg_prep_query (
pkg_conn->prepare_query<package_version> (
"mod-build-task-package-version-query", pq));
// Prepare the build prepared query.
//
// Note that we can not query the database for configurations that a
// package was not built with, as the database contains only those package
// configurations that have already been acted upon (initially empty).
//
// This is why we query the database for package configurations that
// should not be built (in the built state, or in the building state and
// not expired). Having such a list we will select the first build
// configuration that is not in the list (if available) for the response.
//
using bld_query = query<build>;
using prep_bld_query = prepared_query<build>;
package_id id; // See the build query.
const auto& qv (bld_query::id.package.version);
bld_query bq (
bld_query::id.package.name == bld_query::_ref (id.name) &&
qv.epoch == bld_query::_ref (id.version.epoch) &&
qv.canonical_upstream ==
bld_query::_ref (id.version.canonical_upstream) &&
qv.canonical_release == bld_query::_ref (id.version.canonical_release) &&
qv.revision == bld_query::_ref (id.version.revision) &&
bld_query::id.configuration.in_range (cfg_names.begin (),
cfg_names.end ()) &&
compare_version_eq (bld_query::id.toolchain_version,
toolchain_version,
true) &&
(bld_query::state == "built" ||
((bld_query::force == "forcing" &&
bld_query::timestamp > forced_result_expiration_ns) ||
(bld_query::force != "forcing" && // Unforced or forced.
bld_query::timestamp > normal_result_expiration_ns))));
connection_ptr bld_conn (build_db_->connection ());
prep_bld_query bld_prep_query (
bld_conn->prepare_query<build> (
"mod-build-task-package-build-query", bq));
while (tsm.session.empty ())
{
// Start the package database transaction.
//
transaction pt (pkg_conn->begin ());
// Query package versions.
//
auto package_versions (pkg_prep_query.execute ());
// Bail out if there is nothing left.
//
if (package_versions.empty ())
{
pt.commit ();
break;
}
offset += package_versions.size ();
// Start the build database transaction.
//
{
transaction bt (bld_conn->begin (), false);
transaction::current (bt);
// Iterate over packages until we find one that needs building.
//
for (auto& pv: package_versions)
{
id = move (pv.id);
// Iterate through the package configurations and erase those that
// don't need building from the build configuration map. All those
// configurations that remained can be built. We will take the first
// one, if present.
//
// Also save the built package configurations for which it's time
// to be rebuilt.
//
config_machines configs (cfg_machines); // Make a copy for this pkg.
auto pkg_builds (bld_prep_query.execute ());
for (auto i (pkg_builds.begin ()); i != pkg_builds.end (); ++i)
{
auto j (configs.find (i->id.configuration.c_str ()));
// Outdated configurations are already excluded with the database
// query.
//
assert (j != configs.end ());
configs.erase (j);
if (i->state == build_state::built)
{
assert (i->force != force_state::forcing);
if (i->timestamp <= (i->force == force_state::forced
? forced_rebuild_expiration
: normal_rebuild_expiration))
rebuilds.emplace_back (i.load ());
}
}
if (!configs.empty ())
{
config_machine& cm (configs.begin ()->second);
machine_header_manifest& mh (*cm.machine);
build_id bid (move (id), cm.config->name, toolchain_version);
shared_ptr<build> b (build_db_->find<build> (bid));
optional<string> cl (challenge ());
// If build configuration doesn't exist then create the new one
// and persist. Otherwise put it into the building state, refresh
// the timestamp and update.
//
if (b == nullptr)
{
b = make_shared<build> (move (bid.package.name),
move (pv.version),
move (bid.configuration),
move (tqm.toolchain_name),
move (toolchain_version),
move (agent_fp),
move (cl),
mh.name,
move (mh.summary),
cm.config->target);
build_db_->persist (b);
}
else
{
// The package configuration is in the building state, and there
// are no results.
//
// Note that in both cases we keep the status intact to be able
// to compare it with the final one in the result request
// handling in order to decide if to send the notification email.
// The same is true for the forced flag (in the sense that we
// don't set the force state to unforced).
//
// Load the section to assert the above statement.
//
build_db_->load (*b, b->results_section);
assert (b->state == build_state::building &&
b->results.empty ());
b->state = build_state::building;
// Switch the force state not to reissue the task after the
// forced rebuild timeout. Note that the result handler will
// still recognize that the rebuild was forced.
//
if (b->force == force_state::forcing)
b->force = force_state::forced;
b->toolchain_name = move (tqm.toolchain_name);
b->agent_fingerprint = move (agent_fp);
b->agent_challenge = move (cl);
b->machine = mh.name;
b->machine_summary = move (mh.summary);
b->target = cm.config->target;
b->timestamp = timestamp::clock::now ();
build_db_->update (b);
}
// Finally, prepare the task response manifest.
//
// Switch to the package database transaction to load the package.
//
transaction::current (pt);
shared_ptr<package> p (package_db_->load<package> (b->id.package));
p->internal_repository.load ();
// Switch back to the build database transaction.
//
transaction::current (bt);
tsm = task (move (b), move (p), cm);
}
// If the task response manifest is prepared, then bail out from the
// package loop, commit transactions and respond.
//
if (!tsm.session.empty ())
break;
}
bt.commit (); // Commit the build database transaction.
}
transaction::current (pt); // Switch to the package database transaction.
pt.commit ();
}
// If we don't have an unbuilt package, then let's see if we have a
// package to rebuild.
//
if (tsm.session.empty () && !rebuilds.empty ())
{
// Sort the package configuration rebuild list with the following sort
// priority:
//
// 1: force state
// 2: overall status
// 3: timestamp (less is preferred)
//
auto cmp = [] (const shared_ptr<build>& x,
const shared_ptr<build>& y) -> bool
{
if (x->force != y->force)
return x->force > y->force; // Forced goes first.
assert (x->status && y->status); // Both built.
if (x->status != y->status)
return x->status > y->status; // Larger status goes first.
return x->timestamp < y->timestamp; // Older goes first.
};
sort (rebuilds.begin (), rebuilds.end (), cmp);
optional<string> cl (challenge ());
// Pick the first package configuration from the ordered list.
//
// Note that the configurations may not match the required criteria
// anymore (as we have committed the database transactions that were
// used to collect this data) so we recheck. If we find one that matches
// then put it into the building state, refresh the timestamp and
// update. Note that we don't amend the status and the force state to
// have them available in the result request handling (see above).
//
for (auto& b: rebuilds)
{
try
{
transaction bt (build_db_->begin ());
b = build_db_->find<build> (b->id);
if (b != nullptr && b->state == build_state::built &&
b->timestamp <= (b->force == force_state::forced
? forced_rebuild_expiration
: normal_rebuild_expiration))
{
auto i (cfg_machines.find (b->id.configuration.c_str ()));
// Only actual package configurations are loaded (see above).
//
assert (i != cfg_machines.end ());
const config_machine& cm (i->second);
const machine_header_manifest& mh (*cm.machine);
// Load the package (if still present).
//
transaction pt (package_db_->begin (), false);
transaction::current (pt);
shared_ptr<package> p (package_db_->find<package> (b->id.package));
if (p != nullptr)
p->internal_repository.load ();
// Commit the package database transaction and switch back to the
// build database transaction.
//
pt.commit ();
transaction::current (bt);
if (p != nullptr)
{
assert (b->status);
b->state = build_state::building;
b->machine = mh.name;
// Can't move from, as may need them on the next iteration.
//
b->agent_fingerprint = agent_fp;
b->agent_challenge = cl;
b->toolchain_name = tqm.toolchain_name;
b->machine_summary = mh.summary;
b->target = cm.config->target;
// Mark the section as loaded, so results are updated.
//
b->results_section.load ();
b->results.clear ();
b->timestamp = timestamp::clock::now ();
build_db_->update (b);
tsm = task (move (b), move (p), cm);
}
}
bt.commit ();
}
catch (const odb::deadlock&) {} // Just try with the next rebuild.
// If the task response manifest is prepared, then bail out from the
// package configuration rebuilds loop and respond.
//
if (!tsm.session.empty ())
break;
}
}
}
// @@ Probably it would be a good idea to also send some cache control
// headers to avoid caching by HTTP proxies. That would require extension
// of the web::response interface.
//
manifest_serializer s (rs.content (200, "text/manifest;charset=utf-8"),
"task_response_manifest");
tsm.serialize (s);
return true;
}
|