aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBoris Kolpackov <boris@codesynthesis.com>2024-02-14 09:44:08 +0200
committerBoris Kolpackov <boris@codesynthesis.com>2024-02-14 09:44:08 +0200
commit40f84c09974c03405a63c9eba32df7209de4bec0 (patch)
treef5b46b60510ebfcf1870f9b540539bca818ee0ef
parentd0385d4be5f6a483de2d6b1a506d576d08ed547a (diff)
Add comment on json_array assignment issue
-rw-r--r--libbuild2/variable.cxx4
1 files changed, 4 insertions, 0 deletions
diff --git a/libbuild2/variable.cxx b/libbuild2/variable.cxx
index 795af6c..6cdf3ee 100644
--- a/libbuild2/variable.cxx
+++ b/libbuild2/variable.cxx
@@ -2154,6 +2154,10 @@ namespace build2
// Tricky: this can still be JSON input text that is an array. And if
// it's not, then make it an element of an array.
//
+ // @@ Hm, this is confusing: [json_array] a = null ! Maybe not? But then
+ // this won't work: [json_array] a = ([json_array] null). Maybe
+ // distinguish in assign?
+ //
json_value v (to_json_value (ns.front (), "json"));
if (v.type == json_type::array)