Make template definition available in all translation units where used

We were trying to be clever but GCC 10's IPA-SRA optimization didn't like it.

1 files changed, 0 insertions, 27 deletions

diff --git a/libbuild2/cc/common.cxx b/libbuild2/cc/common.cxx
index 6bd9ac3..8150cfa 100644
--- a/libbuild2/cc/common.cxx
+++ b/libbuild2/cc/common.cxx
@@ -487,33 +487,6 @@ namespace build2
       return xt->as<file> ();
     }
 
-    // Insert a target "tagging" it with the specified process path and
-    // verifying that it already exists if requested. Return the lock.
-    //
-    template <typename T>
-    ulock common::
-    insert_library (context& ctx,
-                    T*& r,
-                    string name,
-                    dir_path dir,
-                    const process_path& out,
-                    optional<string> ext,
-                    bool exist,
-                    tracer& trace)
-    {
-      auto p (ctx.targets.insert_locked (T::static_type,
-                                         move (dir),
-                                         path_cast<dir_path> (out.effect),
-                                         name,
-                                         move (ext),
-                                         true, // Implied.
-                                         trace));
-
-      assert (!exist || !p.second.owns_lock ());
-      r = &p.first.template as<T> ();
-      return move (p.second);
-    }
-
     // Note that pk's scope should not be NULL (even if dir is absolute).
     //
     target* common::