aboutsummaryrefslogtreecommitdiff
path: root/libbuild2/dyndep.hxx
diff options
context:
space:
mode:
authorBoris Kolpackov <boris@codesynthesis.com>2021-12-16 07:44:54 +0200
committerBoris Kolpackov <boris@codesynthesis.com>2021-12-16 07:46:09 +0200
commitfb9f2206a3a9b860480d2e9967561b47c1e86351 (patch)
treea0d1f8f6a04144a03307d4ba3cfca979fa969e89 /libbuild2/dyndep.hxx
parentf9e9d10bcb60b807466ddb646a9c0a0a447f7a20 (diff)
Don't consider implied existing targets in dyndep logic
While considering implied targets should be harmless, the result is racy.
Diffstat (limited to 'libbuild2/dyndep.hxx')
-rw-r--r--libbuild2/dyndep.hxx4
1 files changed, 3 insertions, 1 deletions
diff --git a/libbuild2/dyndep.hxx b/libbuild2/dyndep.hxx
index cfd3c7e..ad95df1 100644
--- a/libbuild2/dyndep.hxx
+++ b/libbuild2/dyndep.hxx
@@ -198,7 +198,9 @@ namespace build2
const function<prefix_map_func>& = nullptr,
const srcout_map& = {});
- // As above but do not insert the target if it doesn't already exist.
+ // As above but do not insert the target if it doesn't already exist. This
+ // function also returns NULL if the target exists but is implied (that
+ // is, not declared in a buildfile).
//
static pair<const file*, bool>
find_file (tracer&, const char* what,