From 785c6c6f0aefd54cd883230ba66f34f788c8a248 Mon Sep 17 00:00:00 2001 From: Boris Kolpackov Date: Thu, 16 Sep 2021 15:10:28 +0200 Subject: Fix diagnostics corner case in perform_clean_extra() --- libbuild2/algorithm.cxx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libbuild2/algorithm.cxx b/libbuild2/algorithm.cxx index 52e0926..0370626 100644 --- a/libbuild2/algorithm.cxx +++ b/libbuild2/algorithm.cxx @@ -2470,11 +2470,7 @@ namespace build2 // ft.mtime (timestamp_nonexistent); - // Clean prerequisites. - // - tr |= reverse_execute_prerequisites (a, ft); - - // Factor the result of removing the extra files into the target state. + // We factor the result of removing the extra files into the target state. // While strictly speaking removing them doesn't change the target state, // if we don't do this, then we may end up removing the file but still // saying that everything is clean (e.g., if someone removes the target @@ -2494,6 +2490,10 @@ namespace build2 } } + // Clean prerequisites. + // + tr |= reverse_execute_prerequisites (a, ft); + tr |= er; return tr; } -- cgit v1.1