From aae1d0fd9c98f6b562b28b4c802803bad7c6dce6 Mon Sep 17 00:00:00 2001 From: Boris Kolpackov Date: Wed, 20 May 2020 08:22:27 +0200 Subject: Suppress skip count diagnostics if no progress was requested --- libbuild2/operation.cxx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libbuild2/operation.cxx b/libbuild2/operation.cxx index d56e416..37baddd 100644 --- a/libbuild2/operation.cxx +++ b/libbuild2/operation.cxx @@ -373,9 +373,12 @@ namespace build2 // Print skip count if not zero. Note that we print it regardless of the // diag level since this is essentially a "summary" of all the commands - // that we did not (and, in fact, used to originally) print. + // that we did not (and, in fact, used to originally) print. However, we + // do suppress it if no progress was requested: conceptually, it feels + // like part of the progress report and real usage suggests this as well + // (e.g., when building modules/recipes in a nested context). // - if (verb != 0) + if (prog && verb != 0) { if (size_t s = ctx.skip_count.load (memory_order_relaxed)) { -- cgit v1.1