From 59692f8b9fa2b71711de78d07f031c4866024da4 Mon Sep 17 00:00:00 2001 From: Boris Kolpackov Date: Mon, 13 May 2019 12:18:15 +0200 Subject: Remove order dependence in ad hoc group handling Also, don't match group_recipe since we neither execute nor access the state. --- build2/algorithm.cxx | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'build2/algorithm.cxx') diff --git a/build2/algorithm.cxx b/build2/algorithm.cxx index cb38905..bcdccf6 100644 --- a/build2/algorithm.cxx +++ b/build2/algorithm.cxx @@ -1330,10 +1330,11 @@ namespace build2 // we will also copy .pdb). // // Note that we want to avoid group or tt/patter-spec lookup. And - // since this is an ad hoc member (which means it was added by the - // rule), we assume that the value, if any, will be set as a rule- - // specific variable (since setting it as a target-specific wouldn't - // be MT-safe). + // since this is an ad hoc member (which means it was either declared + // in the buildfile or added by the rule), we assume that the value, + // if any, will be set as a rule-specific variable (since setting it + // as a target-specific wouldn't be MT-safe). @@ Don't think this + // applies to declared ad hoc members. // lookup l (mt->state[a].vars[var_backlink]); -- cgit v1.1