From 04bf0b7cbe98c70d7e434e24a3eb4b03889c0c56 Mon Sep 17 00:00:00 2001
From: Boris Kolpackov <boris@codesynthesis.com>
Date: Thu, 29 Sep 2022 15:17:33 +0200
Subject: Tighten low-verbosity diagnostics name deduction logic

Specifically, don't try to derive low-verbosity name from what looks like an
eval context of a function call.
---
 libbuild2/build/script/parser.cxx | 44 ++++++++++++++++++++++++++++++++++++---
 1 file changed, 41 insertions(+), 3 deletions(-)

(limited to 'libbuild2/build/script/parser.cxx')

diff --git a/libbuild2/build/script/parser.cxx b/libbuild2/build/script/parser.cxx
index 8759cdf..788a782 100644
--- a/libbuild2/build/script/parser.cxx
+++ b/libbuild2/build/script/parser.cxx
@@ -807,10 +807,48 @@ namespace build2
           //
           // This is also the reason why we add a diag frame.
           //
+          // The problem turned out to be worse than originally thought: we
+          // may call a function (for example, as part of if) with invalid
+          // arguments. And this could happen in the depdb preamble, which
+          // means we cannot fix this by moving the depdb builtin (which must
+          // come after the preamble). So let's peek at what's ahead and omit
+          // the expansion if it's anything iffy, namely, eval context or
+          // function call.
+          //
+          bool skip_diag (false);
           if (pre_parse_ && diag_weight_ != 4)
           {
-            pre_parse_ = false; // Make parse_names() perform expansions.
-            pre_parse_suspended_ = true;
+            // Based on the buildfile expansion parsing logic.
+            //
+            if (tt == type::lparen) // Evaluation context.
+              skip_diag = true;
+            else if (tt == type::dollar)
+            {
+              type ptt (peek (lexer_mode::variable));
+
+              if (!peeked ().separated)
+              {
+                if (ptt == type::lparen)
+                {
+                  // While strictly speaking this can also be a function call,
+                  // this is highly unusual and we will assume it's a variable
+                  // expansion.
+                }
+                else if (ptt == type::word)
+                {
+                  pair<char, bool> r (lexer_->peek_char ());
+
+                  if (r.first == '(' && !r.second) // Function call.
+                    skip_diag = true;
+                }
+              }
+            }
+
+            if (!skip_diag)
+            {
+              pre_parse_ = false; // Make parse_names() perform expansions.
+              pre_parse_suspended_ = true;
+            }
           }
 
           auto df = make_diag_frame (
@@ -838,7 +876,7 @@ namespace build2
             pre_parse_ = true;
           }
 
-          if (pre_parse_ && diag_weight_ == 4)
+          if (pre_parse_ && (diag_weight_ == 4 || skip_diag))
             return nullopt;
         }
 
-- 
cgit v1.1