From 2ede341d59b4ab259caf808dfa65c0ac380ba347 Mon Sep 17 00:00:00 2001 From: Boris Kolpackov Date: Tue, 8 Mar 2022 10:57:52 +0200 Subject: Improve performance of update during match for multiple targets --- libbuild2/cc/link-rule.cxx | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) (limited to 'libbuild2/cc') diff --git a/libbuild2/cc/link-rule.cxx b/libbuild2/cc/link-rule.cxx index c507155..b72e5a0 100644 --- a/libbuild2/cc/link-rule.cxx +++ b/libbuild2/cc/link-rule.cxx @@ -1226,17 +1226,13 @@ namespace build2 // example, object file matches may need the headers to be already // updated). // - // Note also that we ignore the result and whether it renders us out of - // date, leaving it to the common execute logic in perform_update(). + // Note that we ignore the result and whether it renders us out of date, + // leaving it to the common execute logic in perform_update(). + // + // Note also that update_during_match() spoils prerequisite_target::data. // if (update_match) - { - for (const prerequisite_target& pto: pts) - { - if ((pto.include & 2) != 0) - update_during_match (trace, a, *pto.target); - } - } + update_during_match (trace, a, pts, 2 /* mask */); // Check if we have any binful utility libraries. // -- cgit v1.1