From e122c6ff4a7f21026332ce9211ad095bd44e71ea Mon Sep 17 00:00:00 2001
From: Boris Kolpackov <boris@codesynthesis.com>
Date: Mon, 29 Jul 2024 12:06:52 +0200
Subject: Fix bug in $string.{contains,ends_with,replace}() (GH issue #405)

These functions use the common rfind() helper which contains the bug.
---
 libbuild2/functions-string.cxx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'libbuild2')

diff --git a/libbuild2/functions-string.cxx b/libbuild2/functions-string.cxx
index eccc6c7..58c17d7 100644
--- a/libbuild2/functions-string.cxx
+++ b/libbuild2/functions-string.cxx
@@ -38,14 +38,14 @@ namespace build2
     {
       n -= sn; // Don't consider characters out of range.
 
-      for (size_t p (n);; )
+      for (size_t p (n);; --p)
       {
         if ((ic
              ? icasecmp (ss, s.c_str () + p, sn)
              : s.compare (p, sn, ss)) == 0)
           return p;
 
-        if (--p == 0)
+        if (p == 0)
           break;
       }
     }
-- 
cgit v1.1