diff options
| author | Boris Kolpackov <boris@codesynthesis.com> | 2020-05-20 08:22:27 +0200 |
|---|---|---|
| committer | Boris Kolpackov <boris@codesynthesis.com> | 2020-05-27 08:33:48 +0200 |
| commit | aae1d0fd9c98f6b562b28b4c802803bad7c6dce6 (patch) | |
| tree | 51a8cc5e4501a2559caa52982598789677179cc3 | |
| parent | 8c0b503ea67abe6fe9483b85d4a1d7f379ee8a1d (diff) | |
Suppress skip count diagnostics if no progress was requested
| -rw-r--r-- | libbuild2/operation.cxx | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/libbuild2/operation.cxx b/libbuild2/operation.cxx index d56e416..37baddd 100644 --- a/libbuild2/operation.cxx +++ b/libbuild2/operation.cxx @@ -373,9 +373,12 @@ namespace build2 // Print skip count if not zero. Note that we print it regardless of the // diag level since this is essentially a "summary" of all the commands - // that we did not (and, in fact, used to originally) print. + // that we did not (and, in fact, used to originally) print. However, we + // do suppress it if no progress was requested: conceptually, it feels + // like part of the progress report and real usage suggests this as well + // (e.g., when building modules/recipes in a nested context). // - if (verb != 0) + if (prog && verb != 0) { if (size_t s = ctx.skip_count.load (memory_order_relaxed)) { |