aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBoris Kolpackov <boris@codesynthesis.com>2023-06-15 09:48:24 +0200
committerBoris Kolpackov <boris@codesynthesis.com>2023-06-15 09:48:24 +0200
commite3c1bd90fd2b26225dbcbda27472ad72f1c575d4 (patch)
treecf9d1991659a9f933704fe58b4d05f7b747911e1
parent493a375346522a0944d4fb5893cc4740e5b2f743 (diff)
Fix incorrect memory order in target::matched() call
-rw-r--r--libbuild2/dyndep.cxx2
-rw-r--r--libbuild2/target.hxx2
2 files changed, 2 insertions, 2 deletions
diff --git a/libbuild2/dyndep.cxx b/libbuild2/dyndep.cxx
index 7fe38d1..c0360f0 100644
--- a/libbuild2/dyndep.cxx
+++ b/libbuild2/dyndep.cxx
@@ -139,7 +139,7 @@ namespace build2
{
diag_record dr;
- if (pt.matched (a))
+ if (pt.matched (a, memory_order_acquire))
{
recipe_function* const* rf (pt[a].recipe.target<recipe_function*> ());
if (rf == nullptr || *rf != &noop_action)
diff --git a/libbuild2/target.hxx b/libbuild2/target.hxx
index 69714fc..aa3df7f 100644
--- a/libbuild2/target.hxx
+++ b/libbuild2/target.hxx
@@ -869,7 +869,7 @@ namespace build2
// This function can only be called during the match or execute phases.
//
// If you need to observe something in the matched target (e.g., the
- // matched rule), use memory_order_acquire.
+ // matched rule or recipe), use memory_order_acquire.
//
bool
matched (action, memory_order mo = memory_order_relaxed) const;