aboutsummaryrefslogtreecommitdiff
path: root/build2/algorithm.cxx
diff options
context:
space:
mode:
authorBoris Kolpackov <boris@codesynthesis.com>2019-05-13 12:18:15 +0200
committerBoris Kolpackov <boris@codesynthesis.com>2019-05-13 12:18:15 +0200
commit59692f8b9fa2b71711de78d07f031c4866024da4 (patch)
tree49962a069bbfcc424a19a524b223f7f82566f8c8 /build2/algorithm.cxx
parentcff78d388133e50d4b930915ae0bb2d0cafe1248 (diff)
Remove order dependence in ad hoc group handling
Also, don't match group_recipe since we neither execute nor access the state.
Diffstat (limited to 'build2/algorithm.cxx')
-rw-r--r--build2/algorithm.cxx9
1 files changed, 5 insertions, 4 deletions
diff --git a/build2/algorithm.cxx b/build2/algorithm.cxx
index cb38905..bcdccf6 100644
--- a/build2/algorithm.cxx
+++ b/build2/algorithm.cxx
@@ -1330,10 +1330,11 @@ namespace build2
// we will also copy .pdb).
//
// Note that we want to avoid group or tt/patter-spec lookup. And
- // since this is an ad hoc member (which means it was added by the
- // rule), we assume that the value, if any, will be set as a rule-
- // specific variable (since setting it as a target-specific wouldn't
- // be MT-safe).
+ // since this is an ad hoc member (which means it was either declared
+ // in the buildfile or added by the rule), we assume that the value,
+ // if any, will be set as a rule-specific variable (since setting it
+ // as a target-specific wouldn't be MT-safe). @@ Don't think this
+ // applies to declared ad hoc members.
//
lookup l (mt->state[a].vars[var_backlink]);