aboutsummaryrefslogtreecommitdiff
path: root/libbuild2/build/script
diff options
context:
space:
mode:
authorBoris Kolpackov <boris@codesynthesis.com>2024-12-12 10:59:37 +0200
committerBoris Kolpackov <boris@codesynthesis.com>2024-12-12 10:59:37 +0200
commit442cf4e38a4661f77b413fc2a90646515d2bee2f (patch)
tree51f0e06127335da737408bf1bb0c9c336e6f0c23 /libbuild2/build/script
parent774ef931b1933cd6a231f9343aee989f6598ab5e (diff)
Fix incorrect logic based on dry_run_option value
Diffstat (limited to 'libbuild2/build/script')
-rw-r--r--libbuild2/build/script/parser.cxx4
1 files changed, 4 insertions, 0 deletions
diff --git a/libbuild2/build/script/parser.cxx b/libbuild2/build/script/parser.cxx
index 3ecf23d..c9193ff 100644
--- a/libbuild2/build/script/parser.cxx
+++ b/libbuild2/build/script/parser.cxx
@@ -2501,6 +2501,10 @@ namespace build2
//
auto fail = [this, what, &ctx] (const auto& f) -> optional<bool>
{
+ // Note that this test will give a false negative if this target
+ // ends up being updated during load or match. At least it's
+ // conservative.
+ //
bool df (!ctx.match_only && !ctx.dry_run_option);
diag_record dr;