aboutsummaryrefslogtreecommitdiff
path: root/libbuild2
diff options
context:
space:
mode:
authorBoris Kolpackov <boris@codesynthesis.com>2024-07-29 12:06:52 +0200
committerBoris Kolpackov <boris@codesynthesis.com>2024-07-29 12:06:52 +0200
commite122c6ff4a7f21026332ce9211ad095bd44e71ea (patch)
treeb05ba5261fdb1089c94760f834f88ef7dcfa0a3a /libbuild2
parentc3212dbda325bdf6eaff6a7652c996a28e8ba688 (diff)
Fix bug in $string.{contains,ends_with,replace}() (GH issue #405)
These functions use the common rfind() helper which contains the bug.
Diffstat (limited to 'libbuild2')
-rw-r--r--libbuild2/functions-string.cxx4
1 files changed, 2 insertions, 2 deletions
diff --git a/libbuild2/functions-string.cxx b/libbuild2/functions-string.cxx
index eccc6c7..58c17d7 100644
--- a/libbuild2/functions-string.cxx
+++ b/libbuild2/functions-string.cxx
@@ -38,14 +38,14 @@ namespace build2
{
n -= sn; // Don't consider characters out of range.
- for (size_t p (n);; )
+ for (size_t p (n);; --p)
{
if ((ic
? icasecmp (ss, s.c_str () + p, sn)
: s.compare (p, sn, ss)) == 0)
return p;
- if (--p == 0)
+ if (p == 0)
break;
}
}